Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalizing the FBC version 3 specification #406

Merged
merged 5 commits into from
Feb 9, 2024

Conversation

bgoli
Copy link
Member

@bgoli bgoli commented Feb 8, 2024

Issues addressed in this PR (addresses #405)

  • implemented the changes suggested in fbc v3: empty lists? #396 allowing empty LoUDC and LoKVP
  • red text removed for a more soothing reader experience
  • fixed an example that was not included properly
  • added a, hopefully, final version of the spec as a PDF sbml-fbc-version-3-release-1.pdf

Copy link
Member

@fbergmann fbergmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bgoli thanks for getting this done, there are still some overflows into the margins, that would be great if we could remove them, worst of them are:

@bgoli
Copy link
Member Author

bgoli commented Feb 8, 2024

Thanks @fbergmann, good points I'll do an overflow check

@luciansmith
Copy link
Member

Chiming in here so I know when this is merged, and I can email sbml-discuss.

@luciansmith
Copy link
Member

There are still other things that need to be fixed, but none of us can actually fix them until this merge happens, because we don't have access to Brett's personal github repository. I'm going ahead and merging this so I can make other fixes and post to sbml-discuss before the JIB deadline.

@luciansmith luciansmith merged commit ea57a59 into sbmlteam:develop Feb 9, 2024
@bgoli
Copy link
Member Author

bgoli commented Jun 14, 2024

What is the status of the V3 specification is there anything else that needs to be done?

@luciansmith
Copy link
Member

I think we're good! Sorry; I thought this was done for the last JIB issue. I merged everything into 'develop', and made a few final changes, mostly to the validation rules relating to the final open issues, including one commit I had made to the wrong branch (sorry). Everything else looks OK, I think. The JIB directory needs work, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fbc-v3: preparing final version FBC: No 'reaction2' in final version of FBC v3 fbc v3: empty lists?
3 participants