-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finalizing the FBC version 3 specification #406
Conversation
…ts, completes fix for sbmlteam#396
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bgoli thanks for getting this done, there are still some overflows into the margins, that would be great if we could remove them, worst of them are:
- url:
\url{https://web.archive.org/web/20151006163154/http://sbml.org/Community/Wiki/SBML_Level_3_Proposals/Flux_Balance_Constraints_Proposal_(2012)} - page 21, line 16 and 25 'http://sbml.org/fbc/keyvaluepair'
- maybe the mailing list link.
Thanks @fbergmann, good points I'll do an overflow check |
Chiming in here so I know when this is merged, and I can email sbml-discuss. |
There are still other things that need to be fixed, but none of us can actually fix them until this merge happens, because we don't have access to Brett's personal github repository. I'm going ahead and merging this so I can make other fixes and post to sbml-discuss before the JIB deadline. |
What is the status of the V3 specification is there anything else that needs to be done? |
I think we're good! Sorry; I thought this was done for the last JIB issue. I merged everything into 'develop', and made a few final changes, mostly to the validation rules relating to the final open issues, including one commit I had made to the wrong branch (sorry). Everything else looks OK, I think. The JIB directory needs work, I think. |
Issues addressed in this PR (addresses #405)
sbml-fbc-version-3-release-1.pdf