Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fbc v3: empty lists? #396

Closed
luciansmith opened this issue Sep 15, 2023 · 2 comments · Fixed by #406
Closed

fbc v3: empty lists? #396

luciansmith opened this issue Sep 15, 2023 · 2 comments · Fixed by #406

Comments

@luciansmith
Copy link
Member

In SBML L3, we generally allow empty lists if the list itself is optional. This is to allow people to annotate the list itself, even if there are no elements in it. Another reason is that another package may extend the class of the contained elements, so to the base package, it might look like it has no children at all, as they are all defined in the derived class.

This isn't a hard rule, but it is what I would call a 'goal' of L3 packages. As such, I would recommend that ListOfUserDefniedConstraints and ListOfKeyValuePairs be allowed to be empty.

(Since ListOfUserDefinedConstraintComponents it itself required, it is reasonable for that to require at least one child.)

@skeating
Copy link
Member

This needs the images to be changed and the source for the pdf2 images is not available in git

bgoli added a commit to bgoli/sbml-specifications that referenced this issue Feb 7, 2024
bgoli added a commit to bgoli/sbml-specifications that referenced this issue Feb 7, 2024
@bgoli bgoli linked a pull request Feb 8, 2024 that will close this issue
luciansmith added a commit that referenced this issue Jun 14, 2024
Don't say that most lists need to not be empty, and do say that ListOfUserDefinedConstraintComponents must have at least one child.
@luciansmith
Copy link
Member Author

Fixed the validation rules corresponding to this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants