Update to be compatible with Faraday #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
pcai
reviewed
Jan 8, 2024
pcai
requested changes
Jan 8, 2024
There was a problem hiding this comment.
did some poking around and found some documentation on the order of parameters for Faraday::Env (which inherits from Options which extends Struct):
https://github.com/lostisland/faraday/blob/main/lib/faraday/options/env.rb#L57
Please make the changes for ruby support < 3.2 and I should be able to cut this as a new release
pcai
reviewed
Jan 8, 2024
|
Looks better. |
|
looks like the coveralls sever is utilizing tlsv1 which is making openssl very unhappy in the builds when coveralls tries to submit its results. |
pcai
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to savonrb/savon#998
Changes some calls to faraday equivalents and updates the tests accordingly