Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.0.0 has a regression with savon versions that depend on httpi #117

Closed
pcai opened this issue Feb 11, 2024 · 1 comment
Closed

5.0.0 has a regression with savon versions that depend on httpi #117

pcai opened this issue Feb 11, 2024 · 1 comment

Comments

@pcai
Copy link
Member

pcai commented Feb 11, 2024

regression is probably from: #116

repro:

expected:

  • tests pass

actual:

(truncated, but this is a representative example):

5) Savon::Client#build_request returns the request without making an actual call
     Failure/Error: unless wsdl.soap_actions.include? operation_name
     
     NoMethodError:
       undefined method `get' for #<HTTPI::Request:0x00007f1871997d58 @read_timeout=10, @follow_redirect=false, @open_timeout=10>
     # /usr/local/rvm/gems/default/gems/wasabi-5.0.0/lib/wasabi/resolver.rb:45:in `load_from_remote'
     # /usr/local/rvm/gems/default/gems/wasabi-5.0.0/lib/wasabi/resolver.rb:35:in `resolve'
     # /usr/local/rvm/gems/default/gems/wasabi-5.0.0/lib/wasabi/document.rb:144:in `xml'
     # /usr/local/rvm/gems/default/gems/wasabi-5.0.0/lib/wasabi/document.rb:162:in `parse'
     # /usr/local/rvm/gems/default/gems/wasabi-5.0.0/lib/wasabi/document.rb:149:in `parser'
     # /usr/local/rvm/gems/default/gems/wasabi-5.0.0/lib/wasabi/document.rb:66:in `soap_actions'
     # ./lib/savon/operation.rb:29:in `ensure_exists!'
     # ./lib/savon/operation.rb:22:in `create'
     # ./lib/savon/client.rb:33:in `operation'
     # ./lib/savon/client.rb:37:in `call'
     # ./spec/support/integration.rb:5:in `call_and_fail_gracefully'
     # ./spec/integration/zipcode_example_spec.rb:23:in `block (4 levels) in <top (required)>'
@pcai
Copy link
Member Author

pcai commented Feb 13, 2024

resolved in 240e10f

@pcai pcai closed this as completed Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant