Don't depend on rack version for public api #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #244
A rewrite of 56cd67b which vendors
Rack::Headers(MIT license) asHTTPI::Utils::Headersso that the public api forHTTPIwon't have to branch on the version ofrackthat is loaded.Rack will still be a dependency, both for its querystring generation at runtime and for testing. But these are implementation details and the runtime dep can be completely removed in the future if desired.
Proposed release strategy: yank 4.0.0 and release this as 4.0.1, making it the first release in the 4.x line with the new API, which will be stable going forward