Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use rack 2.2x headers implementation #249

Merged
merged 2 commits into from
Jun 13, 2024
Merged

use rack 2.2x headers implementation #249

merged 2 commits into from
Jun 13, 2024

Conversation

pcai
Copy link
Member

@pcai pcai commented Jun 13, 2024

Resolves #248

This should have roughly the effect of reverting to an older (more compatible) rack http header hash behavior, even though the public API since v4 is no longer provided by rack itself.

Context: #245

@pcai pcai requested a review from jacklynhma June 13, 2024 17:53
Copy link

@jacklynhma jacklynhma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@pcai pcai merged commit 6ff5867 into main Jun 13, 2024
14 checks passed
@pcai pcai deleted the f/rack-2-headers branch June 13, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Downcasing of header keys breaks bad servers
2 participants