Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #71 by excluding manifest.json from clean #73

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wolph
Copy link

@wolph wolph commented Jan 16, 2020

No description provided.

@ArthurG
Copy link

ArthurG commented May 3, 2020

@samuelsimoes Can you please take a look at this PR?

Copy link

@Zenahr Zenahr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works seamlessly.

@rayronvictor
Copy link

rayronvictor commented Aug 21, 2020

This does not solve the problem of having to copy an entire folder, as when using _locales, while { copyUnmodified: true } does.

For example:

new CopyWebpackPlugin([{
  from: "src/manifest.json",
  transform: function (content, path) {
    // generates the manifest file using the package.json informations
    return Buffer.from(JSON.stringify({
      description: process.env.npm_package_description,
      version: process.env.npm_package_version,
      ...JSON.parse(content.toString())
    }))
  }
},  {
  from: 'src/_locales',
  to: '_locales'
}], {
  copyUnmodified: true
}),

@wolph
Copy link
Author

wolph commented Aug 21, 2020

This does not solve the problem of having to copy an entire folder, as when using _locales, while { copyUnmodified: true } does.

Perhaps that should be added, but when the manifest.json disappears Chrome tends to remove the extension requiring you to re-add it. It definitely should never be deleted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants