Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: always copy manifest file #75

Closed
wants to merge 1 commit into from
Closed

fix: always copy manifest file #75

wants to merge 1 commit into from

Conversation

ksoda
Copy link

@ksoda ksoda commented Mar 8, 2020

Current behaviour:

  1. run webpack as watch mode
  2. modify some file
  3. reload chrome extension
  4. get an error caused by lack of manifest in the build directory

The copyUnmodified option fixes this problem

Out of scope: JS Style format

Current behaviour:
1. run webpack as watch mode
2. modify some file
3. reload chrome extension
4. get an error caused by lack of manifest in the build directory
@ksoda
Copy link
Author

ksoda commented Mar 8, 2020

This is already described in #71 (comment) ;)

@ksoda ksoda changed the title fix: copy always manifest file fix: always copy manifest file Mar 8, 2020
@ksoda
Copy link
Author

ksoda commented Mar 8, 2020

I think the #73's approach is better than this one. That change may achieve a higher performance. 🤔

@ksoda ksoda closed this Jul 4, 2020
@ksoda ksoda deleted the copy-manifest-in-watch-mode branch July 4, 2020 14:54
@rayronvictor
Copy link

I think the #73's approach is better than this one. That change may achieve a higher performance. 🤔

#73 approach does not solve the problem of having to copy an entire folder, as when using _locales, while { copyUnmodified: true } does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants