fix: update near-membrane-dom to use ShadowRealm #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwaldron
force-pushed
the
rwaldron/shadow-realm
branch
from
c3b74c3 to
72cb157
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
rwaldron
force-pushed
the
rwaldron/shadow-realm
branch
from
72cb157 to
1632390
Compare
rwaldron
commented
Feb 23, 2022
This comment was marked as outdated.
This comment was marked as outdated.
rwaldron
force-pushed
the
rwaldron/shadow-realm
branch
12 times, most recently
from
b779833 to
ba26311
Compare
rwaldron
force-pushed
the
rwaldron/shadow-realm
branch
from
ba26311 to
4de4482
Compare
|
Safari Technology Preview 142 was released today with Shadow Realms enabled by default! No need for any custom builds anymore! https://developer.apple.com/safari/resources/ |
This comment was marked as resolved.
This comment was marked as resolved.
rwaldron
force-pushed
the
rwaldron/shadow-realm
branch
from
4de4482 to
84fd7f8
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
jdalton
reviewed
Mar 24, 2022
jdalton
reviewed
Mar 24, 2022
jdalton
reviewed
Mar 24, 2022
rwaldron
force-pushed
the
rwaldron/shadow-realm
branch
2 times, most recently
from
cce74a6 to
cd5bd5d
Compare
rwaldron
force-pushed
the
rwaldron/shadow-realm
branch
2 times, most recently
from
1560704 to
efc13dc
Compare
caridy
reviewed
May 24, 2022
caridy
reviewed
May 24, 2022
caridy
reviewed
May 24, 2022
caridy
reviewed
May 24, 2022
caridy
reviewed
May 24, 2022
caridy
reviewed
May 24, 2022
rwaldron
force-pushed
the
rwaldron/shadow-realm
branch
from
a779456 to
8015e03
Compare
rwaldron
force-pushed
the
rwaldron/shadow-realm
branch
2 times, most recently
from
9e9bd91 to
20e42a9
Compare
rwaldron
force-pushed
the
rwaldron/shadow-realm
branch
from
20e42a9 to
fe2e858
Compare
|
Rebased! |
rwaldron
force-pushed
the
rwaldron/shadow-realm
branch
5 times, most recently
from
aded7b4 to
03fb83c
Compare
rwaldron
commented
Jan 25, 2023
| @@ -296,6 +296,7 @@ export class VirtualEnvironment { | |||
| for (let i = 0, { length } = keys; i < length; i += 1) { | |||
| const key = keys[i]; | |||
| bluePointer = this.blueCallableGetPropertyValuePointer(bluePointer, key); | |||
| // This is where the failure occurs. | |||
There was a problem hiding this comment.
and what exactly is the error? this has been around forever I think
There was a problem hiding this comment.
Expected function not to throw, but it threw TypeError: return value not primitive or callable.
rwaldron
force-pushed
the
rwaldron/shadow-realm
branch
from
03fb83c to
8a4eb37
Compare
…on in near-membrane
rwaldron
force-pushed
the
rwaldron/shadow-realm
branch
from
8a4eb37 to
4dd46b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This "sort of" works. You have to get the build info from @leobalter, make sure you're running the build correctly (which isn't obvious) and then run the karma tests using the default Chrome run. Grab the url from your console and paste into the nightly webkit build and it will run (there are no dev tools). Currently the tests fail with:See #243 (comment)