-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wasm32-wasip2 target support #532
base: master
Are you sure you want to change the base?
Conversation
The build failure seems to be coming from the fact that |
That's nice spot Rust put us in... We're not going to increase the MSRV with also doing a version bump, which I don't want to any time soon to be honest. Maybe we can say the MSRV for wasi p2 is higher? It's not ideal, but I don't see any other solution. |
Seems okay to me. |
@nickrum what is the status of this? |
5b81c68
to
b09d256
Compare
@Thomasdezeeuw This was blocked by a release of libc containing rust-lang/libc#3981 and should be ready for review now.
FreeBSD is currently failing because of #534, which will be fixed by #535. |
The
wasm32-wasip2
target will be a tier 2 target starting with Rust 1.82 and will gain improved socket support in Rust 1.83, so it felt like it made sense to add support for WASIp2 now. If WASIp1 support is a requirement for merging this, I can look into that as well.Tests are all passing locally. They can be run by having
wasmtime
installed and settingCARGO_TARGET_WASM32_WASIP2_RUNNER="wasmtime --wasi inherit-network"
.Marked as a draft for now since some definitions should be move to rust/libc before merging. I'll do that as soon as I get confirmation on the general direction of this PR.
Closes #268