Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wasm32-wasip2 definitions necessary for socket2 support #3981

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Add wasm32-wasip2 definitions necessary for socket2 support #3981

merged 1 commit into from
Oct 24, 2024

Conversation

nickrum
Copy link
Contributor

@nickrum nickrum commented Oct 16, 2024

@rustbot
Copy link
Collaborator

rustbot commented Oct 16, 2024

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@tgross35
Copy link
Contributor

@alexcrichton could you double check this?

alexcrichton
alexcrichton approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me!

tgross35
tgross35 approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks all!

@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Oct 24, 2024
@tgross35 tgross35 added this pull request to the merge queue Oct 24, 2024
Merged via the queue into rust-lang:main with commit 81f0cd3 Oct 24, 2024
40 checks passed
@nickrum nickrum deleted the wasip2-socket2 branch October 24, 2024 19:41
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Nov 6, 2024
@nickrum @tgross35
Add wasm32-wasip2 definitions necessary for socket2 support
c916d57 
(backport <rust-lang#3981>)
(cherry picked from commit 1300509)
@tgross35 tgross35 mentioned this pull request Nov 6, 2024
Merged
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Nov 6, 2024
@shadow3aaa shadow3aaa mentioned this pull request Nov 8, 2024
Merged
@nickrum nickrum mentioned this pull request Nov 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgross35 tgross35 tgross35 approved these changes

@alexcrichton alexcrichton alexcrichton approved these changes

Assignees

@tgross35 tgross35

Labels
S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nickrum @rustbot @tgross35 @alexcrichton