Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli/rustup-mode): allow rustup doc with both a flag and a topic #4070

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

feat(cli/rustup-mode): allow rustup doc with both a flag and a topic #4070

wants to merge 11 commits into from
+140 −77

Commits on Nov 26, 2024

  1. refactor(cli/rustup-mode): use early return in doc()

    @rami3l
    rami3l committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    86a7570 View commit details
    Browse the repository at this point in the history

  2. refactor(cli/topical-doc): clean up some funtions

    @rami3l
    rami3l committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    7551b5e View commit details
    Browse the repository at this point in the history

  3. refactor(cli/rustup-mode): move DocPage::name() to a separate `impl… 

    …` block
    @rami3l
    rami3l committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    562ab03 View commit details
    Browse the repository at this point in the history

  4. refactor(cli/rustup-mode): make DocPage::path() return Option<&Path>

    @rami3l
    rami3l committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    f9cfad4 View commit details
    Browse the repository at this point in the history

  5. refactor(cli/rustup-mode): rename doc_url to doc_path

    @rami3l
    rami3l committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    ee4cf67 View commit details
    Browse the repository at this point in the history

  6. refactor(toolchain): simplify Toolchain::doc_path()

    @rami3l
    rami3l committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    a25ba4f View commit details
    Browse the repository at this point in the history

  7. refactor(toolchain): allow absolute paths in Toolchain::doc_path()

    @rami3l
    rami3l committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    d82509b View commit details
    Browse the repository at this point in the history

  8. refactor(toolchain): allow passing a fragment in Toolchain::doc_path()

    @rami3l
    rami3l committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    a98aaeb View commit details
    Browse the repository at this point in the history

  9. feat(cli/rustup-mode): allow rustup doc with both a flag and a topic

    @rami3l
    rami3l committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    43757fb View commit details
    Browse the repository at this point in the history

  10. refactor(test/mock): use tuples for topical_doc_data::TEST_CASES

    @rami3l
    rami3l committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    53aea77 View commit details
    Browse the repository at this point in the history

  11. test(mock/topical-doc-data): add test cases with both a flag and a topic

    @rami3l
    rami3l committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    602e1a2 View commit details
    Browse the repository at this point in the history