-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli/rustup-mode): allow rustup doc
with both a flag and a topic
#4070
Open
rami3l
wants to merge
11
commits into
rust-lang:master
Choose a base branch
from
rami3l:feat/doc-topic-and-flag
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+140
−77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rami3l
force-pushed
the
feat/doc-topic-and-flag
branch
from
November 9, 2024 16:03
8e99ab6
to
a1f70d7
Compare
rami3l
force-pushed
the
feat/doc-topic-and-flag
branch
from
November 26, 2024 13:47
a1f70d7
to
43757fb
Compare
PS: The CI failures seem irrelevant to the changes being made in this PR. |
This was referenced Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is my stab at the concern in #4069.
However, I think
rustup
should not magically detect and acknowledge lints, so I've made a more neutral solution that might apply to more topics:Concerns
Should we add test cases for this PR, and how may we add them?Added--path
tests to ensure that we can get the doc paths right.