-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
N28: Oxygengine + NavMesh #875
N28: Oxygengine + NavMesh #875
Conversation
i've used GIF hosted on my repo since these never change and GIF no matter how much i optimize it, it refuses to go down to 2 MB : D |
i've replaced links to external gif with one bound to specific commit to preserve it when file gets moved or replaced or something |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Text content looks good, just made a couple of tweaks for readability.
I'm still slightly wary of the size of the image - hosting it elsewhere avoids it taking up space in the repo, but the reader still has to download it (for context, the previous issue of the newsletter was 15mb total, most of which was people's GIFs...). It's not the end of the world, but it's not very friendly to people on mobile/limited data plans.
cc @AngelOnFira, not sure what your thoughts on this are.
if needed i could cut length of the gif till gets 2 mb, but 10 seconds is already short tho |
@PsichiX I'm going to make the decision to say that Gifs and other media must be hosted on our repo, and must be smaller than 2.5MB to be included. Although I believe you won't edit that commit, and it should be available, I do still believe that it could cause a headache down the road if something did go wrong. Having the media in our repo does provide a strong guarantee around that. As for size, that is a strong restriction regardless. Gifs aren't the greatest format for size, maybe we can look into mp4 down the line, but we don't have that now :) Hopefully this works for you! |
I'll try to revisit #636 later this month, if I get time - GIF wrangling always ends up being a fairly large chunk of the review process (through no fault of the contributors, makes perfect sense to want to show games in motion), and I feel like there has to be an easier way :) |
ok, will cut the length (lowering resolution only increases the size xD) |
ok, i've cut length of the gif animation to 2.5 mb @17cupsofcoffee @AngelOnFira |
Part of #852