chore: fix flaky e2e test #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henry118
reviewed
Sep 17, 2024
cezar-r
force-pushed
the
flaky-e2e-test
branch
from
b8bde5d to
f09e1a2
Compare
Signed-off-by: Cezar Rata <[email protected]>
cezar-r
force-pushed
the
flaky-e2e-test
branch
from
f09e1a2 to
57ef08c
Compare
henry118
approved these changes
Sep 17, 2024
coderbirju
approved these changes
Sep 17, 2024
This was referenced Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Instead of waiting a fixed 5 seconds for container to restart (which sometimes could take longer, leading to a failed test), the test now polls the container until its restarted.
Testing done:
Passed all unit and e2e tests
E2E tests passed on 5/5 attempts
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.