Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add release automation #28

Merged
merged 8 commits into from
Sep 18, 2024

Conversation

coderbirju
Copy link
Contributor

@coderbirju coderbirju commented Sep 9, 2024

needs #40 #42
Issue #, if available:

Description of changes:

Testing done:

  • I've reviewed the guidance in CONTRIBUTING.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@coderbirju coderbirju force-pushed the add-release-automation branch from 6d3bc49 to 5b517db Compare September 9, 2024 17:25
@coderbirju coderbirju changed the title Add release automation ci: Add release automation Sep 9, 2024
@coderbirju coderbirju force-pushed the add-release-automation branch 2 times, most recently from 6efc25c to fc5d54c Compare September 13, 2024 15:15
scripts/create-releases.sh Show resolved Hide resolved
.github/workflows/release-automation.yaml Outdated Show resolved Hide resolved
@coderbirju coderbirju force-pushed the add-release-automation branch from b83795c to 277a725 Compare September 13, 2024 15:57
@coderbirju coderbirju force-pushed the add-release-automation branch from 277a725 to 4d123d6 Compare September 13, 2024 16:40
henry118
henry118 previously approved these changes Sep 13, 2024
Copy link
Member

@henry118 henry118 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@henry118
Copy link
Member

Actually, @coderbirju can you also verify that the packaged binary finch-daemon has the same version as the release?

@coderbirju
Copy link
Contributor Author

Updated the release-automation to install go-licenses globally.

Actually, @coderbirju can you also verify that the packaged binary finch-daemon has the same version as the release?

The verify-release-artifacts.sh script checks the packaged binary is the same version as the release tag.

@coderbirju coderbirju requested a review from henry118 September 13, 2024 21:51
@henry118
Copy link
Member

Updated the release-automation to install go-licenses globally.

Actually, @coderbirju can you also verify that the packaged binary finch-daemon has the same version as the release?

The verify-release-artifacts.sh script checks the packaged binary is the same version as the release tag.

I might have missed it but I don't see it's happening. I am referring the the validation of the output of finch-daemon --version.

@henry118
Copy link
Member

Updated the release-automation to install go-licenses globally.

Actually, @coderbirju can you also verify that the packaged binary finch-daemon has the same version as the release?

The verify-release-artifacts.sh script checks the packaged binary is the same version as the release tag.

I might have missed it but I don't see it's happening. I am referring the the validation of the output of finch-daemon --version.

Oh just realized that we currently do not have that option. But we need to verify it's /version api then.

@henry118
Copy link
Member

@coderbirju #40 could be useful

@coderbirju coderbirju force-pushed the add-release-automation branch from 9cdb2eb to 513dfe4 Compare September 17, 2024 02:06
@coderbirju coderbirju force-pushed the add-release-automation branch 2 times, most recently from 1bf990f to 9574265 Compare September 17, 2024 05:56
cezar-r
cezar-r previously approved these changes Sep 17, 2024
Copy link
Member

@henry118 henry118 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coderbirju coderbirju enabled auto-merge (squash) September 18, 2024 17:55
Signed-off-by: Arjun Raja Yogidas <[email protected]>
Signed-off-by: Arjun Raja Yogidas <[email protected]>
Signed-off-by: Arjun Raja Yogidas <[email protected]>
@coderbirju coderbirju force-pushed the add-release-automation branch from e9ee71b to ee9a34e Compare September 18, 2024 17:56
@coderbirju coderbirju disabled auto-merge September 18, 2024 17:56
@coderbirju coderbirju merged commit 7d2640c into runfinch:main Sep 18, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants