Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return an error if custom bridge name is not set successfully #100

Merged
merged 1 commit into from
Nov 19, 2024
Merged

fix: return an error if custom bridge name is not set successfully #100

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/service/network/driver/bridge.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ func (bd *bridgeDriver) HandlePostCreate(net *netutil.NetworkConfig) (string, er
// Since nerdctl currently does not support custom bridge names,
// we explicitly override bridge name in the conflist file for the network that was just created
if err = bd.setBridgeName(net, bridgeName); err != nil {
warning = fmt.Sprintf("Failed to set network bridge name %s: %s", bridgeName, err)
return "", fmt.Errorf("failed to set network bridge name %s: %s", bridgeName, err)
}
}

Expand Down
Loading