fix: return an error if custom bridge name is not set successfully #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swagatbora90
force-pushed
the
return_err_on_set_bridgename
branch
from
5eed7a5 to
d028402
Compare
swagatbora90
changed the title
Signed-off-by: Swagat Bora <[email protected]>
swagatbora90
force-pushed
the
return_err_on_set_bridgename
branch
from
d028402 to
468acbc
Compare
Shubhranshu153
approved these changes
Nov 18, 2024
Shubhranshu153
previously approved these changes
Nov 18, 2024
pendo324
previously approved these changes
Nov 18, 2024
Shubhranshu153
dismissed stale reviews from pendo324 and themself
The merge-base changed after approval.
Shubhranshu153
approved these changes
Nov 19, 2024
pendo324
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Addressing a comment from the PR #69 (comment)
Description of changes:
If the option to configure custom bridge name is set, finch-daemon will try to set the bridge name by updating the CNI conflist of the network. However, on failure, it will simply return a warning instead of failing. This change returns an explicit error if an error is encountered.
The created Network will be removed as part of a defer cleanup in Create.
Testing done:
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.