Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add a delay for system event monitoring to start before pull completes as the run commands are async #144

Merged
merged 3 commits into from
Mar 28, 2024
Merged

fix: add a delay for system event monitoring to start before pull completes as the run commands are async #144

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6832214
fix: add custom wait for retry logic
Shubhranshu153 Mar 27, 2024
f871292
Merge branch 'runfinch:main' into main
Shubhranshu153 Mar 28, 2024
666aedd
fix: add a delay for system event monitoring to start before pull com…
Shubhranshu153 Mar 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions tests/events.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,13 @@ func Events(o *option.Option) {
ginkgo.It("should get real time events from command", func() {
session := command.RunWithoutWait(o, "system", "events")
defer session.Kill()

// Give time for the system events to be running and monitoring before pull is called.
time.Sleep(5 * time.Second)

gomega.Expect(session.Out.Contents()).Should(gomega.BeEmpty())
command.Run(o, "pull", localImages[defaultImage])

// allow propagation time
gomega.Eventually(func(session *gexec.Session) string {
return strings.TrimSpace(string(session.Out.Contents()))
Expand Down
Loading