fix: add a delay for system event monitoring to start before pull completes as the run commands are async #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shubharanshu Mahapatra <[email protected]>
…pletes as the run commands are async Signed-off-by: Shubharanshu Mahapatra <[email protected]>
pendo324
approved these changes
Mar 28, 2024
Shubhranshu153
pushed a commit
that referenced
this pull request
Mar 28, 2024
🤖 I have created a release *beep* *boop* --- ## [0.7.21](v0.7.20...v0.7.21) (2024-03-28) ### Bug Fixes * add a delay for system event monitoring to start before pull completes as the run commands are async ([#144](#144)) ([5de585f](5de585f)) * add custom wait for retry logic ([#141](#141)) ([3b69319](3b69319)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This test fails around 50% of time in windows
adding the delay ensures system event process has started before the commands it monitors are running. This is a async call so this fix is required.
Testing done:
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.