Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nodes Selected by Default #73

Merged
merged 4 commits into from
Oct 6, 2023
Merged

Nodes Selected by Default #73

merged 4 commits into from
Oct 6, 2023

Conversation

fdevans
Copy link
Contributor

@fdevans fdevans commented Jul 27, 2021

PR #11 source was removed. Thanks @ProTip for the help on the issue earlier.

Enhancement Details:
There is a setting on Rundeck jobs to select nodes by default or require the job runner to select nodes from the defined node filter.
Screen Shot 2021-07-27 at 9 54 48 AM

A setting of true equates to "Target nodes are selected by default"
A setting of false equates to "The user has to explicitly select target nodes"

PR #11 source was removed.  This should implement the same functionality but getting a build error.
@fdevans fdevans requested a review from ProTip July 27, 2021 17:18
@ProTip ProTip removed their request for review September 2, 2021 17:06
@endersonmenezes
Copy link

@fdevans any news from this repo? I'm looking for this function and I ended up parachuting into your PR.

@fdevans
Copy link
Contributor Author

fdevans commented Feb 1, 2022

The developer that used to collaborate with me on these left recently, so we are working on getting someone else up to speed to help with reviews. We have a few other priorities in Q1, but hope to revisit all these soon.

@fdevans fdevans mentioned this pull request Feb 2, 2022
@fdevans fdevans requested a review from qualman March 22, 2022 22:46
@apopescu
Copy link

hi @fdevans any chance to have this merged soon? we really need that some of our jobs to not have selected all the target nodes by default. Thanks!

@fdevans fdevans removed the request for review from qualman September 28, 2023 20:36
@fdevans fdevans merged commit aed8fac into master Oct 6, 2023
6 checks passed
@fdevans fdevans deleted the nodes-selected-by-default branch October 7, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants