Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nodes selected by default #12

Closed

Conversation

rumenvasilev
Copy link

@rumenvasilev rumenvasilev commented Jan 4, 2018

I've updated go-rundeck-api to the latest master and have adapted a few bits to work with the changes.
This PR is mainly adding support for the following options:

  • nodes_selected_by_default
  • execution_enabled (coming from the latest apparentlymart/go-rundeck-api)
  • schedule_enabled (coming from the latest apparentlymart/go-rundeck-api)

Documentation is also updated.
It is already running on a few instances of rundeck in production already with no side effects.

@rumenvasilev
Copy link
Author

This one implements the previous PR https://github.com/terraform-providers/terraform-provider-rundeck/pull/11

@rumenvasilev
Copy link
Author

@grubernaut @radeksimko @apparentlymart
Guys can I get a review on this? :)

@roccato
Copy link

roccato commented Aug 29, 2018

Any chance this can get a review? @grubernaut @radeksimko @apparentlymart

@fdevans
Copy link
Contributor

fdevans commented Jul 27, 2021

Hi @rumenvasilev. We are working on catching up on these. Are these enhancements still needed?

@fdevans
Copy link
Contributor

fdevans commented Feb 2, 2022

Nodes Selected by Default is covered in #73
We will confirm if the other options still need code added to support them. Opened Issue #74 for tracking and closing this one since there is quite a few conflicts to manage and will likely be faster to reimplement from the current state.

@fdevans fdevans closed this Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants