-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: separation prs for ut and dt dedicated deployment updates #3936
Open
sanpj2292
wants to merge
5
commits into
develop
Choose a base branch
from
chore.dedicate-prs-ut-dt
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
f1c33db
chore: dedicated deployments separation for ut and dt
b160455
chore: update commit msg for dt
9c8f36d
chore: update ut dedicated deployment branch and commit msg
2e53f2e
chore: update branch for dedicated ut deployment
c42630c
Merge remote-tracking branch 'origin/develop' into chore.dedicate-prs…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
name: Prepare for UT Production Environment Deployment | ||
|
||
on: | ||
push: | ||
|
@@ -29,6 +29,7 @@ | |
if: ((startsWith(github.event.pull_request.head.ref, 'release/') || startsWith(github.event.pull_request.head.ref, 'hotfix-release/')) && github.event.pull_request.merged == true) | ||
outputs: | ||
tag_name_ut: ${{ steps.gen_tag_names.outputs.tag_name_ut }} | ||
tag_name: ${{ steps.gen_tag_names.outputs.tag_name }} | ||
steps: | ||
- name: Checkout | ||
uses: actions/[email protected] | ||
|
@@ -71,6 +72,7 @@ | |
needs: [generate-tag-names, build-user-transformer-image] | ||
env: | ||
UT_TAG_NAME: ${{ needs.generate-tag-names.outputs.tag_name_ut }} | ||
TAG_NAME: ${{ needs.generate-tag-names.outputs.tag_name }} | ||
TF_IMAGE_REPOSITORY: rudderstack/rudder-transformer | ||
steps: | ||
- name: Checkout | ||
|
@@ -134,3 +136,39 @@ | |
git push -u origin hosted-user-transformer-$UT_TAG_NAME | ||
|
||
gh pr create --fill | ||
|
||
- name: Update helm charts and raise pull request for enterprise customers on dedicated transformers | ||
env: | ||
GITHUB_TOKEN: ${{ secrets.PAT }} | ||
run: | | ||
cd rudder-devops | ||
git checkout -b dedicated-user-transformer-$TAG_NAME | ||
|
||
cd customer-objects | ||
|
||
declare -a enabled_ut_customers=() | ||
declare -a sub_directories=('enterprise-us' 'enterprise-eu') | ||
|
||
# identify the customers enabled in sub-directories | ||
for directory in "${sub_directories[@]}"; do | ||
for f in "./$directory"/*; do | ||
[[ -f $f ]] || continue | ||
|
||
enabled="$(yq e '.spec.user_transformer.enabled' $f)" | ||
if [ $enabled == "true" ]; then | ||
enabled_ut_customers+=( $f ) | ||
fi | ||
done | ||
done | ||
|
||
# bump up the customers version and repository information | ||
for customer in "${enabled_ut_customers[@]}"; do | ||
yq eval -i ".spec.user_transformer.image.version=\"$TAG_NAME\"" $customer | ||
yq eval -i ".spec.user_transformer.image.repository=\"$TF_IMAGE_REPOSITORY\"" $customer | ||
git add $customer | ||
done | ||
|
||
git commit -m "chore: upgrade dedicated user transformers to $TAG_NAME" | ||
git push -u origin dedicated-user-transformer-$TAG_NAME | ||
|
||
gh pr create --fill |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure whether DM team wants to track these every release - otherwise PR's are gonna be in hanging state cc: @Jayachand
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
user-transformers have special needs to put on dedicated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May be we can move the production UT deployment to a manual trigger rather than on merge to
main
(current state). @Jayachand any thoughts here ? Will there be any repurcussions due to this ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc: @abhimanyubabbar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we saying to deploy UT to production customers ( shared ones ) as well through a manual trigger ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only move production UT deployment to a manual trigger.