-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: separation prs for ut and dt dedicated deployment updates #3936
base: develop
Are you sure you want to change the base?
Conversation
Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/3936/test-report.html |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3936 +/- ##
===========================================
+ Coverage 90.48% 90.50% +0.01%
===========================================
Files 615 620 +5
Lines 32359 32518 +159
Branches 7687 7712 +25
===========================================
+ Hits 29281 29429 +148
- Misses 2822 2833 +11
Partials 256 256 ☔ View full report in Codecov by Sentry. |
@@ -134,3 +136,39 @@ jobs: | |||
git push -u origin hosted-user-transformer-$UT_TAG_NAME | |||
|
|||
gh pr create --fill | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure whether DM team wants to track these every release - otherwise PR's are gonna be in hanging state cc: @Jayachand
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
user-transformers have special needs to put on dedicated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May be we can move the production UT deployment to a manual trigger rather than on merge to main
(current state). @Jayachand any thoughts here ? Will there be any repurcussions due to this ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc: @abhimanyubabbar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we saying to deploy UT to production customers ( shared ones ) as well through a manual trigger ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only move production UT deployment to a manual trigger.
Quality Gate passedIssues Measures |
What are the changes introduced in this PR?
We have separated dedicated deployments for UT and DT
What is the related Linear task?
Resolves INT-2977
Please explain the objectives of your changes below
Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here
Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?
N/A
Any new dependencies introduced with this change?
N/A
Any new generic utility introduced or modified. Please explain the changes.
N/A
Any technical or performance related pointers to consider with the change?
N/A
@coderabbitai review
Developer checklist
My code follows the style guidelines of this project
No breaking changes are being introduced.
All related docs linked with the PR?
All changes manually tested?
Any documentation changes needed with this change?
Is the PR limited to 10 file changes?
Is the PR limited to one linear task?
Are relevant unit and component test-cases added in new readability format?
Reviewer checklist
Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.