Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enhancement: introduce user model for one signal #3499

Merged
merged 11 commits into from
Jun 25, 2024

Conversation

anantjain45823
Copy link
Contributor

What are the changes introduced in this PR?

Onboarding new api version for onesignal for User Schema referenced as V2 in code.
One Signal Docs

What is the related Linear task?

Resolves INT-2234

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@anantjain45823 anantjain45823 self-assigned this Jun 24, 2024
@anantjain45823 anantjain45823 requested review from a team and sivashanmukh as code owners June 24, 2024 15:13
@anantjain45823 anantjain45823 requested review from sanpj2292 and sandeepdsvs and removed request for a team June 24, 2024 15:13
@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 93.95973% with 9 lines in your changes missing coverage. Please review.

Project coverage is 88.05%. Comparing base (2fc4d6b) to head (1976e74).
Report is 339 commits behind head on hotfix/one_signal_user_schema.

Files Patch % Lines
src/v0/destinations/one_signal/util.js 89.83% 4 Missing and 2 partials ⚠️
src/v0/destinations/one_signal/transformV2.js 96.34% 3 Missing ⚠️
Additional details and impacted files
@@                        Coverage Diff                        @@
##           hotfix/one_signal_user_schema    #3499      +/-   ##
=================================================================
+ Coverage                          87.30%   88.05%   +0.74%     
=================================================================
  Files                                541      571      +30     
  Lines                              29325    30940    +1615     
  Branches                            6995     7405     +410     
=================================================================
+ Hits                               25603    27244    +1641     
+ Misses                              3379     3358      -21     
+ Partials                             343      338       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@anantjain45823 anantjain45823 merged commit 1c8e950 into hotfix/one_signal_user_schema Jun 25, 2024
15 checks passed
@anantjain45823 anantjain45823 deleted the feat.updateOneSignal branch June 25, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants