fix: enhancement: onboard user API for onesignal #3457
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/3457/test-report.html |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3457 +/- ##
===========================================
+ Coverage 88.05% 88.10% +0.05%
===========================================
Files 577 580 +3
Lines 31164 31382 +218
Branches 7430 7486 +56
===========================================
+ Hits 27440 27650 +210
- Misses 3414 3420 +6
- Partials 310 312 +2 ☔ View full report in Codecov by Sentry. |
shrouti1507
previously approved these changes
Jun 20, 2024
shrouti1507
previously approved these changes
Jun 24, 2024
Gauravudia
previously approved these changes
Jun 24, 2024
anantjain45823
dismissed stale reviews from Gauravudia and shrouti1507
via
2c27a6c
utsabc
reviewed
Jun 24, 2024
|
Test cases are failing need to fix it |
|
For Unit test cases we will cover them afterwards |
|
anantjain45823
changed the title
anantjain45823
changed the base branch from
develop
to
hotfix/one_signal_user_schema
anantjain45823
changed the base branch from
hotfix/one_signal_user_schema
to
develop
|
Moved to #3499 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this PR?
Onboarding new api version for onesignal for User Schema referenced as V2 in code.
One Signal Docs
What is the related Linear task?
Resolves INT-2234
Please explain the objectives of your changes below
Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here
Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?
N/A
Any new dependencies introduced with this change?
N/A
Any new generic utility introduced or modified. Please explain the changes.
N/A
Any technical or performance related pointers to consider with the change?
N/A
@coderabbitai review
Developer checklist
My code follows the style guidelines of this project
No breaking changes are being introduced.
All related docs linked with the PR?
All changes manually tested?
Any documentation changes needed with this change?
Is the PR limited to 10 file changes?
Is the PR limited to one linear task?
Are relevant unit and component test-cases added in new readability format?
Reviewer checklist
Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.