Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enhancement: onboard user API for onesignal #3457

Closed
wants to merge 12 commits into from

chore: address comments

ef0a1b1
Select commit
Loading
Failed to load commit list.
Closed

fix: enhancement: onboard user API for onesignal #3457

chore: address comments
ef0a1b1
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 24, 2024 in 0s

88.10% (+0.05%) compared to d655fd1

View this Pull Request on Codecov

88.10% (+0.05%) compared to d655fd1

Details

Codecov Report

Attention: Patch coverage is 93.95973% with 9 lines in your changes missing coverage. Please review.

Project coverage is 88.10%. Comparing base (d655fd1) to head (ef0a1b1).
Report is 10 commits behind head on develop.

Files Patch % Lines
src/v0/destinations/one_signal/util.js 89.83% 4 Missing and 2 partials ⚠️
src/v0/destinations/one_signal/transformV2.js 96.34% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3457      +/-   ##
===========================================
+ Coverage    88.05%   88.10%   +0.05%     
===========================================
  Files          577      580       +3     
  Lines        31164    31382     +218     
  Branches      7430     7486      +56     
===========================================
+ Hits         27440    27650     +210     
- Misses        3414     3420       +6     
- Partials       310      312       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.