Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enhancement: onboard user API for onesignal #3457

Closed
wants to merge 12 commits into from

chore: add test cases+2

b4f201d
Select commit
Loading
Failed to load commit list.
Closed

fix: enhancement: onboard user API for onesignal #3457

chore: add test cases+2
b4f201d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 21, 2024 in 0s

88.09% (+0.04%) compared to d655fd1

View this Pull Request on Codecov

88.09% (+0.04%) compared to d655fd1

Details

Codecov Report

Attention: Patch coverage is 94.50549% with 10 lines in your changes missing coverage. Please review.

Project coverage is 88.09%. Comparing base (d655fd1) to head (b4f201d).
Report is 5 commits behind head on develop.

Current head b4f201d differs from pull request most recent head 9f4614e

Please upload reports for the commit 9f4614e to get more accurate results.

Files Patch % Lines
src/v0/destinations/one_signal/utils.js 92.30% 5 Missing and 2 partials ⚠️
src/v0/destinations/one_signal/transformV2.js 96.34% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3457      +/-   ##
===========================================
+ Coverage    88.05%   88.09%   +0.04%     
===========================================
  Files          577      578       +1     
  Lines        31164    31293     +129     
  Branches      7430     7467      +37     
===========================================
+ Hits         27440    27568     +128     
+ Misses        3414     3385      -29     
- Partials       310      340      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.