Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: no success should return empty array for linkedin ads #3238

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

shrouti1507
Copy link
Contributor

What are the changes introduced in this PR?

we were not handling the scenario where no successful events will be present. Hence raising the PR

What is the related Linear task?

Resolves INT-XXX

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@shrouti1507 shrouti1507 requested a review from a team as a code owner April 2, 2024 13:20
@shrouti1507 shrouti1507 requested review from krishna2020, sanpj2292 and koladilip and removed request for a team April 2, 2024 13:20
@shrouti1507 shrouti1507 self-assigned this Apr 2, 2024
@shrouti1507 shrouti1507 changed the title chore: no success should return empty array chore: no success should return empty array for linkedin ads Apr 2, 2024
@devops-github-rudderstack
Copy link
Contributor

Copy link

sonarqubecloud bot commented Apr 2, 2024

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 87.78%. Comparing base (476b401) to head (f0528ab).

Files Patch % Lines
src/cdk/v2/destinations/linkedin_ads/utils.js 50.00% 1 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##           release/v1.61.0    #3238      +/-   ##
===================================================
- Coverage            87.78%   87.78%   -0.01%     
===================================================
  Files                  556      556              
  Lines                29829    29831       +2     
  Branches              7106     7107       +1     
===================================================
+ Hits                 26186    26187       +1     
- Misses                3335     3336       +1     
  Partials               308      308              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shrouti1507 shrouti1507 merged commit aaddac1 into release/v1.61.0 Apr 2, 2024
17 checks passed
@shrouti1507 shrouti1507 deleted the fix.linkedinAds_successEmpty branch April 2, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants