chore: no success should return empty array for linkedin ads (#3238)

chore: no success should return empty array
rudderlabs · Apr 2, 2024 · aaddac1 · aaddac1
1 parent 476b401
commit aaddac1
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/src/cdk/v2/destinations/linkedin_ads/rtWorkflow.yaml b/src/cdk/v2/destinations/linkedin_ads/rtWorkflow.yaml
@@ -1,6 +1,8 @@
 bindings:
   - path: ./utils
   - path: ./config
+  - name: handleRtTfSingleEventError
+    path: ../../../../v0/util/index
 
 steps:
   - name: validateInput
@@ -23,14 +25,9 @@ steps:
       })[]
   - name: failedEvents
     template: |
-      $.outputs.transform#idx.error.({
-        "metadata": ^[idx].metadata[],
-        "destination": ^[idx].destination,
-        "batched": false,
-        "statusCode": .status,
-        "error": .message,
-        "statTags": .originalError.statTags
-      })[]
+      $.outputs.transform#idx.error.(
+        $.handleRtTfSingleEventError(^[idx], .originalError ?? ., {})
+      )[]
 
   - name: batchSuccessfulEvents
     description: Batches the successfulEvents

diff --git a/src/cdk/v2/destinations/linkedin_ads/utils.js b/src/cdk/v2/destinations/linkedin_ads/utils.js
@@ -162,6 +162,9 @@ const fetchAndVerifyConversionHappenedAt = (message) => {
 };
 
 function batchResponseBuilder(successfulEvents) {
+  if (successfulEvents.length === 0) {
+    return [];
+  }
   const constants = {
     version: successfulEvents[0].message[0].version,
     type: successfulEvents[0].message[0].type,