fix: adding map for marketo known values and javascript known values #3037
Conversation
|
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
|
Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/3037/test-report.html |
1 similar comment
|
Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/3037/test-report.html |
|
Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/3037/test-report.html |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3037 +/- ##
===========================================
+ Coverage 87.09% 87.14% +0.04%
===========================================
Files 530 530
Lines 28803 28802 -1
Branches 6859 6858 -1
===========================================
+ Hits 25087 25099 +12
+ Misses 3371 3360 -11
+ Partials 345 343 -2 ☔ View full report in Codecov by Sentry. |
src/v0/destinations/marketo_bulk_upload/marketo_bulk_upload.util.test.js
Show resolved
Hide resolved
|
Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/3037/test-report.html |
|
Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/3037/test-report.html |
|
Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/3037/test-report.html |
|
Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/3037/test-report.html |
|
What are the changes introduced in this PR?
While running sync for a customer and we have come accross invalid id error for a huge number of events.
While debugging we found out that the data delivery was happening seemlessly but we have issue in reporting the failure and warning events.
while returning errors or warnings, marketo sends back all the fields of the erroneous events, along with its values and reason for failure, but no job ids are sent back
This the reason, we match all the events we already sent ( field-value ) to marketo with the response we get back from marketo.
The response itself can be clumsy and not so readable at various times. Upon research, we have seen that, if the data type of a field inside Marketo ( that we are making sure to get by sending one axios get call ) does not match with the data type that users send, it sends back a warning. That is why, we are checking, if data types are matching or not.
Now javascript understands 5 types of variables types:
we had considered any other data types of data to be of type
string.For example : marketo has
emailas a datatype, which is not easy for us to track. But for any email, thetypeOffunction returns string.But we missed the logic that even if we consider email as
string, the initial data type from marketo field is stillemail.That is why this PR contains a suitable mapping for marketo known and javascript known data types
What is the related Linear task?
Resolves INT-1446
Please explain the objectives of your changes below
Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here
Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?
Reason:
For example : marketo has
emailas a datatype, which is not easy for us to track. But for any email, thetypeOffunction returns string.But we missed the logic that even if we consider email as
string, the initial data type from marketo field is stillemail.Changes :
We added a map which we convert marketo specific data types to javascript specific data types.
Example :
email --> string
integer --> number
Any new dependencies introduced with this change?
N/A
Any new generic utility introduced or modified. Please explain the changes.
N/A
Any technical or performance related pointers to consider with the change?
N/A
Developer checklist
My code follows the style guidelines of this project
No breaking changes are being introduced.
All related docs linked with the PR?
All changes manually tested?
Any documentation changes needed with this change?
Is the PR limited to 10 file changes?
Is the PR limited to one linear task?
Are relevant unit and component test-cases added?
Reviewer checklist
Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.