fix: making error statement better

rudderlabs · Jan 30, 2024 · d7d6bfb · d7d6bfb
1 parent 67ac4bb
commit d7d6bfb
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/v0/destinations/marketo_bulk_upload/marketo_bulk_upload.util.test.js b/src/v0/destinations/marketo_bulk_upload/marketo_bulk_upload.util.test.js
@@ -408,7 +408,7 @@ describe('checkEventStatusViaSchemaMatching', () => {
     const result = checkEventStatusViaSchemaMatching(event, fieldSchemaMapping);
 
     expect(result).toEqual({
-      job1: 'invalid email',
+      job1: 'invalid email for value 123 ',
     });
   });
 
@@ -448,8 +448,8 @@ describe('checkEventStatusViaSchemaMatching', () => {
     const result = checkEventStatusViaSchemaMatching(event, fieldSchemaMapping);
 
     expect(result).toEqual({
-      job1: 'invalid id',
-      job2: 'invalid testCustomFieldScore',
+      job1: 'invalid id for value value1 ',
+      job2: 'invalid testCustomFieldScore for value false ',
     });
   });
 
@@ -505,7 +505,7 @@ describe('checkEventStatusViaSchemaMatching', () => {
     const result = checkEventStatusViaSchemaMatching(event, fieldSchemaMapping);
 
     expect(result).toEqual({
-      job1: 'invalid abc',
+      job1: 'invalid abc for value value2 ',
     });
   });
 
@@ -534,7 +534,7 @@ describe('checkEventStatusViaSchemaMatching', () => {
     const result = checkEventStatusViaSchemaMatching(event, fieldSchemaMapping);
 
     expect(result).toEqual({
-      job1: 'invalid id',
+      job1: 'invalid id for value null ',
     });
   });
 });
diff --git a/src/v0/destinations/marketo_bulk_upload/util.js b/src/v0/destinations/marketo_bulk_upload/util.js
@@ -406,7 +406,7 @@ const checkEventStatusViaSchemaMatching = (event, fieldMap) => {
       const actualDataType = typeof paramValue;
 
       if (!mismatchedFields[job_id] && actualDataType !== expectedDataType) {
-        mismatchedFields[job_id] = `invalid ${paramName}`;
+        mismatchedFields[job_id] = `invalid ${paramName} for value ${paramValue} `;
       }
     });
   });