Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: record to audience handling #2813

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 51 additions & 0 deletions src/v0/destinations/marketo_static_list/testData/constants.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
const EXTERNAL_ID = 'marketoStaticListId';
const TOKEN = 'Bearer access_token_success';
const CONTENT_TYPE = 'application/json';
const DEST_OBJECT = {
ID: '1zwa1wKshSt81YksKmUdJnr4IOK',
Name: 'test_marketo_rc',
DestinationDefinition: {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not use DEST_DEFINITION here?

ID: '1iVQvTRMsPPyJzwol0ifH93QTQ6',
Name: 'MARKETO',
DisplayName: 'Marketo',
transformAt: 'processor',
transformAtV1: 'processor',
Comment on lines +11 to +12
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change this to router

},
Config: {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here why not use DEST_CONFIG

clientId: 'marketo_client_id_success',
clientSecret: 'marketo_client_secret_success',
accountId: 'marketo_acct_id_success',
staticListId: 1122,
},
Enabled: true,
Transformations: [],
IsProcessorEnabled: true,
};
const DEST_DEFINITION = {
ID: '1iVQvTRMsPPyJzwol0ifH93QTQ6',
Name: 'MARKETO',
DisplayName: 'Marketo',
transformAt: 'processor',
transformAtV1: 'processor',
};
const MESSAGE_SOURCES_CONTEXT = {
job_id: '2VsZs4hyPpq7f1p8igrpmHsibHl',
job_run_id: 'ck99nbd2kqiljdihhkh0',
task_run_id: 'ck99nbd2kqiljdihhkhg',
};
const DEST_CONFIG = {
clientId: 'marketo_client_id_success',
clientSecret: 'marketo_client_secret_success',
accountId: 'marketo_acct_id_success',
staticListId: 1234,
};

module.exports = {
EXTERNAL_ID,
TOKEN,
CONTENT_TYPE,
DEST_OBJECT,
DEST_DEFINITION,
MESSAGE_SOURCES_CONTEXT,
DEST_CONFIG,
};
Loading
Loading