-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: record to audience handling #2813
Merged
utsabc
merged 8 commits into
feat.onboard.record.event.support.msl
from
fix.record-to-audience-handling
Nov 22, 2023
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
1aee8cb
refactor transformation for record to audience list flow
utsabc 29e6913
fix: seperate handling flows of record and audiencelist event
yashasvibajpai 6ab439e
fix: update implementation for record event handle
utsabc 598376c
fix: bug fix for pushing transformed responses to final response list
utsabc 530d51a
chore: add record test
yashasvibajpai 2ddd740
chore: add unit tests
yashasvibajpai 47a7e0c
chore: fix sonar issue
yashasvibajpai 5c50c51
fix: externalId type for record, refactor cases
yashasvibajpai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
51 changes: 51 additions & 0 deletions
51
src/v0/destinations/marketo_static_list/testData/constants.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
const EXTERNAL_ID = 'marketoStaticListId'; | ||
const TOKEN = 'Bearer access_token_success'; | ||
const CONTENT_TYPE = 'application/json'; | ||
const DEST_OBJECT = { | ||
ID: '1zwa1wKshSt81YksKmUdJnr4IOK', | ||
Name: 'test_marketo_rc', | ||
DestinationDefinition: { | ||
ID: '1iVQvTRMsPPyJzwol0ifH93QTQ6', | ||
Name: 'MARKETO', | ||
DisplayName: 'Marketo', | ||
transformAt: 'processor', | ||
transformAtV1: 'processor', | ||
Comment on lines
+11
to
+12
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Change this to router |
||
}, | ||
Config: { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same here why not use |
||
clientId: 'marketo_client_id_success', | ||
clientSecret: 'marketo_client_secret_success', | ||
accountId: 'marketo_acct_id_success', | ||
staticListId: 1122, | ||
}, | ||
Enabled: true, | ||
Transformations: [], | ||
IsProcessorEnabled: true, | ||
}; | ||
const DEST_DEFINITION = { | ||
ID: '1iVQvTRMsPPyJzwol0ifH93QTQ6', | ||
Name: 'MARKETO', | ||
DisplayName: 'Marketo', | ||
transformAt: 'processor', | ||
transformAtV1: 'processor', | ||
}; | ||
const MESSAGE_SOURCES_CONTEXT = { | ||
job_id: '2VsZs4hyPpq7f1p8igrpmHsibHl', | ||
job_run_id: 'ck99nbd2kqiljdihhkh0', | ||
task_run_id: 'ck99nbd2kqiljdihhkhg', | ||
}; | ||
const DEST_CONFIG = { | ||
clientId: 'marketo_client_id_success', | ||
clientSecret: 'marketo_client_secret_success', | ||
accountId: 'marketo_acct_id_success', | ||
staticListId: 1234, | ||
}; | ||
|
||
module.exports = { | ||
EXTERNAL_ID, | ||
TOKEN, | ||
CONTENT_TYPE, | ||
DEST_OBJECT, | ||
DEST_DEFINITION, | ||
MESSAGE_SOURCES_CONTEXT, | ||
DEST_CONFIG, | ||
}; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not use
DEST_DEFINITION
here?