fix: record to audience handling #2813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utsabc
changed the base branch from
develop
to
feat.onboard.record.event.support.msl
chandumlg
approved these changes
Nov 20, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat.onboard.record.event.support.msl #2813 +/- ##
========================================================================
Coverage ? 87.22%
========================================================================
Files ? 774
Lines ? 28606
Branches ? 6670
========================================================================
Hits ? 24952
Misses ? 3317
Partials ? 337 ☔ View full report in Codecov by Sentry. |
|
Kudos, SonarCloud Quality Gate passed! |
utsabc
commented
Nov 22, 2023
Comment on lines
+11
to
+12
| transformAt: 'processor', | ||
| transformAtV1: 'processor', |
| const DEST_OBJECT = { | ||
| ID: '1zwa1wKshSt81YksKmUdJnr4IOK', | ||
| Name: 'test_marketo_rc', | ||
| DestinationDefinition: { |
There was a problem hiding this comment.
why not use DEST_DEFINITION here?
| transformAt: 'processor', | ||
| transformAtV1: 'processor', | ||
| }, | ||
| Config: { |
There was a problem hiding this comment.
Same here why not use DEST_CONFIG
utsabc
merged commit 996dcc8
into
feat.onboard.record.event.support.msl
16 checks passed
yashasvibajpai
added a commit
that referenced
this pull request
Dec 11, 2023
* feat: onboard msl changes for new record event * chore: remove older tc for MSL * fix: metadata * fix: metadatax2 * chore: address comments * chore: address commentsx2, handle mix of audiencelist and record events * chore: address commentsx2, handle mix of audiencelist and record events * chore: add router test * fix: record to audience handling (#2813) * fix: unit case with empty request * fix: missed error lib * chore: refactor tests * refactor: address comments * chore: address commentsx2 * fix: error message, handle metadata, missing id --------- Co-authored-by: Utsab Chowdhury <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Handle for transformation flow for record to audiencelist type
Type of change
Related issues
Checklists
Development
Code review