Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove flattening customData in FB Conversions and FB Pixel #2787

Closed
wants to merge 3 commits into from

feat: revert removal of flattenJson in fb pixel and handle content_id…

91f78ba
Select commit
Loading
Failed to load commit list.
Closed

feat: remove flattening customData in FB Conversions and FB Pixel #2787

feat: revert removal of flattenJson in fb pixel and handle content_id…
91f78ba
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 2, 2023 in 0s

87.17% (+0.03%) compared to c38f14f

View this Pull Request on Codecov

87.17% (+0.03%) compared to c38f14f

Details

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (c38f14f) 87.13% compared to head (91f78ba) 87.17%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2787      +/-   ##
===========================================
+ Coverage    87.13%   87.17%   +0.03%     
===========================================
  Files          766      766              
  Lines        28443    28469      +26     
  Branches      6655     6646       -9     
===========================================
+ Hits         24785    24818      +33     
+ Misses        3321     3314       -7     
  Partials       337      337              
Files Coverage Δ
src/v0/destinations/facebook_pixel/transform.js 96.19% <50.00%> (-1.83%) ⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.