Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove flattening customData in FB Conversions and FB Pixel #2787

Closed
wants to merge 3 commits into from

Conversation

sandeepdsvs
Copy link
Contributor

@sandeepdsvs sandeepdsvs commented Nov 1, 2023

Description of the change

Resolves INT-925
With this change, objects and arrays in message.properties won't be flattened anymore before sending them to the destination as part of custom_data.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (c38f14f) 87.13% compared to head (91f78ba) 87.17%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2787      +/-   ##
===========================================
+ Coverage    87.13%   87.17%   +0.03%     
===========================================
  Files          766      766              
  Lines        28443    28469      +26     
  Branches      6655     6646       -9     
===========================================
+ Hits         24785    24818      +33     
+ Misses        3321     3314       -7     
  Partials       337      337              
Files Coverage Δ
src/v0/destinations/facebook_pixel/transform.js 96.19% <50.00%> (-1.83%) ⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sandeepdsvs sandeepdsvs changed the title feat: set flattenArray to false while flattening customData in FB Conversions and FB Pixel feat: remove flattening customData in FB Conversions and FB Pixel Nov 1, 2023
@sandeepdsvs sandeepdsvs marked this pull request as draft November 1, 2023 21:57
Copy link

sonarqubecloud bot commented Nov 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

44.4% 44.4% Coverage
0.0% 0.0% Duplication

@devops-github-rudderstack devops-github-rudderstack deleted the fb_remove_flatten_array branch February 3, 2024 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant