Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bugsnag event sent as an object for track call #2681

Merged
merged 6 commits into from
Oct 11, 2023

Conversation

anantjain45823
Copy link
Contributor

Description of the change

Resolves INT-752
For track call event sent as an object resulted in some alerts. This PR resolves those

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (99f39f5) 87.12% compared to head (3131ad7) 87.13%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2681   +/-   ##
========================================
  Coverage    87.12%   87.13%           
========================================
  Files          639      639           
  Lines        28411    28409    -2     
  Branches      6735     6733    -2     
========================================
+ Hits         24754    24755    +1     
+ Misses        3329     3326    -3     
  Partials       328      328           
Files Coverage Δ
src/v0/destinations/customerio/util.js 95.65% <100.00%> (+1.13%) ⬆️
src/v0/destinations/freshsales/transform.js 96.80% <100.00%> (+1.01%) ⬆️
src/v0/destinations/monday/transform.js 97.87% <100.00%> (-0.05%) ⬇️
src/v0/destinations/monday/util.js 96.61% <100.00%> (ø)
src/v0/util/index.js 87.69% <100.00%> (+0.04%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mihir-4116
mihir-4116 previously approved these changes Oct 4, 2023
@sanpj2292
Copy link
Contributor

@anantjain45823
Let's write a common validator function for checking eventType. Ask everyone to only use it.

@anantjain45823
Copy link
Contributor Author

We can have validation based upon message.type and basic request schema.
Does that sound good?

@sanpj2292
Copy link
Contributor

We can have validation based upon message.type and basic request schema.
Does that sound good?

Let us solve this problem via a common validator. The other thing of basic request schema validation, let us do it later.

@anantjain45823
Copy link
Contributor Author

We can have validation based upon message.type and basic request schema.
Does that sound good?

Let us solve this problem via a common validator. The other thing of basic request schema validation, let us do it later.

Done

@sanpj2292 sanpj2292 requested a review from mihir-4116 October 5, 2023 04:48
@sanpj2292 sanpj2292 self-requested a review October 5, 2023 08:11
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@anantjain45823 anantjain45823 merged commit b211840 into develop Oct 11, 2023
14 checks passed
@anantjain45823 anantjain45823 deleted the fix.bugsnagIssues branch December 13, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants