chore:comment addresed

src/v0/destinations/customerio/util.js

@@ -2,7 +2,6 @@ const get = require('get-value');
 const set = require('set-value');
 const truncate = require('truncate-utf8-bytes');
 const { MAX_BATCH_SIZE, configFieldsToCheck } = require('./config');
-const logger = require('../../../logger');
 const {
   constructPayload,
   defaultPutRequestConfig,
@@ -11,6 +10,7 @@ const {
   defaultDeleteRequestConfig,
   isAppleFamily,
   validateEmail,
+  validateEventType,
 } = require('../../util');
 
 const { EventType, SpecedTraits, TraitsMapping } = require('../../../constants');
@@ -288,10 +288,7 @@ const defaultResponseBuilder = (message, evName, userId, evType, destination, me
       // 100 - len(`Viewed  Screen`) = 86
       trimmedEvName = `Viewed ${truncate(message.event || message.properties.name, 86)} Screen`;
     } else {
-      if (!evName || typeof evName !== 'string') {
-        logger.error(`Could not determine event name`);
-        throw new InstrumentationError(`Could not determine event name`);
-      }
+      validateEventType(evName);
       trimmedEvName = truncate(evName, 100);
     }
     // anonymous_id needs to be sent for anon track calls to provide information on which anon user is being tracked

src/v0/destinations/freshsales/transform.js

@@ -8,6 +8,7 @@ const {
   defaultPostRequestConfig,
   getValidDynamicFormConfig,
   simpleProcessRouterDest,
+  validateEventType,
 } = require('../../util');
 const { InstrumentationError, TransformationError } = require('../../util/errorTypes');
 const { CONFIG_CATEGORIES, MAPPING_CONFIG } = require('./config');
@@ -66,9 +67,7 @@ const identifyResponseBuilder = (message, { Config }) => {
  * @returns
  */
 const trackResponseBuilder = async (message, { Config }, event) => {
-  if (!event || typeof event !== 'string') {
-    throw new InstrumentationError('String Event name is required for track call.');
-  }
+  validateEventType(event);
   let payload;
 
   const response = defaultRequestConfig();

src/v0/destinations/monday/transform.js

@@ -8,6 +8,7 @@ const {
   removeUndefinedAndNullValues,
   simpleProcessRouterDest,
   getDestinationExternalID,
+  validateEventType,
 } = require('../../util');
 const {
   ConfigurationError,
@@ -40,21 +41,14 @@ const responseBuilder = (payload, endpoint, apiToken) => {
 const trackResponseBuilder = async (message, { Config }) => {
   const { apiToken } = Config;
   let boardId = getDestinationExternalID(message, 'boardId');
-  if (!message?.event || typeof message.event !== 'string') {
-    throw new InstrumentationError('Event name is required and it should be string');
-  }
+  const event = get(message, 'event');
+  validateEventType(event);
   if (!boardId) {
     boardId = Config.boardId;
   }
   if (!boardId) {
     throw new ConfigurationError('boardId is a required field');
   }
-  const event = get(message, 'event');
-
-  if (!event || typeof event !== 'string') {
-    throw new InstrumentationError('Event name is required and it should be string');
-  }
-
   if (!checkAllowedEventNameFromUI(event, Config)) {
     throw new ConfigurationError('Event Discarded. To allow this event, add this in Allowlist');
   }

src/v0/util/index.js

@@ -2025,6 +2025,11 @@ const getAuthErrCategoryFromStCode = (status) => {
   return '';
 };
 
+const validateEventType = event => {
+  if(!event || typeof event !== "string"){
+    throw new InstrumentationError("Event is a required field and should be a string");
+  }
+}
 // ========================================================================
 // EXPORTS
 // ========================================================================
@@ -2118,6 +2123,7 @@ module.exports = {
   getDestAuthCacheInstance,
   refinePayload,
   validateEmail,
+  validateEventType,
   validatePhoneWithCountryCode,
   getEventReqMetadata,
   isHybridModeEnabled,

test/__tests__/data/customerio_output.json

@@ -1,6 +1,6 @@
 [
   {
-    "message": "Could not determine event name"
+    "message": "Event is a required field and should be a string"
   },
   {
     "body": {

test/__tests__/data/freshsales.json

@@ -75,7 +75,7 @@
     },
     "output": {
       "statusCode": 400,
-      "error": "String Event name is required for track call.",
+      "error": "Event is a required field and should be a string",
       "statTags": {
         "errorAt": "proc",
         "destType": "FRESHMARKETER",

test/__tests__/data/monday.json

@@ -428,7 +428,7 @@
       }
     },
     "output": {
-      "error": "Event name is required and it should be string"
+      "error": "Event is a required field and should be a string"
     }
   },
   {