Skip to content

Commit

Permalink
feat: move cdkV1 to cdkv2 component tests (#2804)
Browse files Browse the repository at this point in the history
* feat: move cdkV1 to cdkv2 component test
  • Loading branch information
aashishmalik authored Nov 10, 2023
1 parent 0e14296 commit 195b48a
Show file tree
Hide file tree
Showing 19 changed files with 10,302 additions and 125 deletions.
10 changes: 3 additions & 7 deletions src/cdk/v2/handler.ts
Original file line number Diff line number Diff line change
Expand Up @@ -65,13 +65,9 @@ export function getCachedWorkflowEngine(
}

export async function executeWorkflow(workflowEngine: WorkflowEngine, parsedEvent: FixMe) {
try {
const result = await workflowEngine.execute(parsedEvent);
// TODO: Handle remaining output scenarios
return result.output;
} catch (error) {
throw getErrorInfo(error, isCdkV2Destination(parsedEvent), defTags);
}
const result = await workflowEngine.execute(parsedEvent);
// TODO: Handle remaining output scenarios
return result.output;
}

export async function processCdkV2Workflow(
Expand Down
3 changes: 2 additions & 1 deletion test/apitests/data_scenarios/cdk_v2/failure.json
Original file line number Diff line number Diff line change
Expand Up @@ -646,7 +646,8 @@
"statusCode": 400,
"error": "Action source must be one of app_android, app_ios, web, offline: Workflow: procWorkflow, Step: validateCommonFields, ChildStep: undefined, OriginalError: Action source must be one of app_android, app_ios, web, offline",
"statTags": {
"errorCategory": "platform",
"errorCategory": "dataValidation",
"errorType": "instrumentation",
"implementation": "cdkV2",
"destType": "PINTEREST_TAG",
"module": "destination",
Expand Down
Loading

0 comments on commit 195b48a

Please sign in to comment.