feat: add clickId support for tiktok and pinterest destination (#2784)

* feat: add clickId support for tiktok * feat: add clickId support for pinterest * chore: add clickId in tests * chore: correct mapping for tiktok * chore: remove instances of callback in input * fix: add clickId in tests * fix: revert context.page mapping
rudderlabs · Nov 10, 2023 · 0e14296 · 0e14296
1 parent 42bec54
commit 0e14296
Show file tree

Hide file tree

Showing 5 changed files with 4,675 additions and 4,721 deletions.
diff --git a/src/cdk/v2/destinations/pinterest_tag/procWorkflow.yaml b/src/cdk/v2/destinations/pinterest_tag/procWorkflow.yaml
@@ -100,7 +100,8 @@ steps:
         "hashed_maids": .context.device.advertisingId,
         "client_ip_address": .context.ip ?? .request_ip,
         "client_user_agent": .context.userAgent,
-        "external_id": {{{{$.getGenericPaths("userId")}}}}
+        "external_id": {{{{$.getGenericPaths("userId")}}}},
+        "click_id": .properties.clickId
       });
       !.destination.Config.sendExternalId ?  userFields = userFields{~["external_id"]} : null;
       userFields = $.removeUndefinedAndNullAndEmptyValues(userFields);
@@ -185,14 +186,13 @@ steps:
   - name: payload
     template: |
       $.outputs.eventNames.().({...$.outputs.basePayload, event_name: .})[]
-    
+
   - name: checkSendTestEventConfig
     description: |
       If sendTestEvent is enabled, we send test event to the destination
       ref: https://help.pinterest.com/en/business/article/track-conversions-with-the-conversions-api
     template: |
-        ^.destination.Config.sendAsTestEvent ? {"test": true} : {}
-        
+      ^.destination.Config.sendAsTestEvent ? {"test": true} : {}
 
   - name: buildResponseForBatchMode
     description: In batchMode we return payload directly

diff --git a/src/v0/destinations/tiktok_ads/data/TikTokTrack.json b/src/v0/destinations/tiktok_ads/data/TikTokTrack.json
@@ -72,6 +72,11 @@
     "sourceKeys": ["properties.context.ad", "context.ad"],
     "required": false
   },
+  {
+    "destKey": "context.ad.callback",
+    "sourceKeys": "properties.clickId",
+    "required": false
+  },
   {
     "destKey": "context.page",
     "sourceKeys": ["properties.context.page", "context.page"],

diff --git a/test/integrations/destinations/pinterest_tag/processor/data.ts b/test/integrations/destinations/pinterest_tag/processor/data.ts
@@ -44,6 +44,7 @@ export const data = [
                 order_id: '50314b8e9bcf000000000000',
                 requestIP: '123.0.0.0',
                 optOutType: 'LDP',
+                clickId: 'dummy_clickId',
                 products: [
                   {
                     sku: '45790-32',
@@ -132,6 +133,7 @@ export const data = [
                       '6ca13d52ca70c883e0f0bb101e425a89e8624de51db2d2392593af6a84118090',
                     ],
                     client_user_agent: 'chrome',
+                    click_id: 'dummy_clickId',
                     ge: ['1b16b1df538ba12dc3f97edbb85caa7050d46c148134290feba80f8236c83db9'],
                   },
                   custom_data: {