Commits on Oct 8, 2024

1. bootc: Make rpm-ostree directly output to stdout, stderr …

   I think it's cleanest now to just have rpm-ostree output directly to the
   stdout and stderr of the parent DNF process (usually the terminal).
   There are several problems with trying to capture it and output it
   through the `logger` interface:
   
   - Where do stderr messages from rpm-ostree go? Are they errors?
     Warnings? Critical? We don't know.
   - rpm-ostree is EXTREMELY SLOW and users need to see its progress in
     realtime. It has progress animations that wouldn't display
     right if we tried to buffer an entire line of output and then print it
     all at once with logger.info().
   - Colors are missing from rpm-ostree output when stdout is not isatty.
     We could emulate a terminal (probably bad) or have rpm-ostree add a
     --color=on flag to override.
   
   Lots of other dnf-plugins-core plugins `print` messages directly
   stdout, so bootc would not be an exception here.

   

   evan-goode committed Oct 8, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 0d3e2b0
   • Browse repository at this point

   Copy the full SHA

   0d3e2b0 View commit details

   Browse the repository at this point in the history

2. bootc: Exit with rpm-ostree's return code …

   This is necessary if we want to support rpm-ostree's `--pending-exit-77`
   flag. Maybe a cleaner solution could be to bring over libdnf5's
   `SilentCommandExitError(int exit_code)`.

   

   evan-goode committed Oct 8, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 85a8e1d
   • Browse repository at this point

   Copy the full SHA

   85a8e1d View commit details

   Browse the repository at this point in the history