bootc: Simplify I/O with rpm-ostree subprocess #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcantrell
reviewed
Oct 8, 2024
dcantrell
approved these changes
Oct 8, 2024
I think it's cleanest now to just have rpm-ostree output directly to the stdout and stderr of the parent DNF process (usually the terminal). There are several problems with trying to capture it and output it through the `logger` interface: - Where do stderr messages from rpm-ostree go? Are they errors? Warnings? Critical? We don't know. - rpm-ostree is EXTREMELY SLOW and users need to see its progress in realtime. It has progress animations that wouldn't display right if we tried to buffer an entire line of output and then print it all at once with logger.info(). - Colors are missing from rpm-ostree output when stdout is not isatty. We could emulate a terminal (probably bad) or have rpm-ostree add a --color=on flag to override. Lots of other dnf-plugins-core plugins `print` messages directly stdout, so bootc would not be an exception here.
This is necessary if we want to support rpm-ostree's `--pending-exit-77` flag. Maybe a cleaner solution could be to bring over libdnf5's `SilentCommandExitError(int exit_code)`.
evan-goode
force-pushed
the
evan-goode/bootc-stdin-stdout
branch
from
627c162
to
85a8e1d
Compare
|
Rebased and added a missing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages.
Also merges changes from master branch.
For https://issues.redhat.com/browse/SWM-3432