Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tp_call.h fix field type for tracepoint event rclcpp_ring_buffer_enqueue (backport #117) #119

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jun 10, 2024

Reason for this pull request:

While trying to compile ros2 on my system with gcc-14 i got an integer conversion warning causing a compilation failure:

error: initialization of ‘const uint64_t *’ {aka ‘const long unsigned int *’} from ‘uint64_t’ {aka ‘long unsigned int’} makes pointer from integer without a cast [-Wint-conversion]
  474 |     ctf_integer(const uint64_t *, index, index_arg)

Proposed fix:

As far as i see it, the field type should match the argument type in this case.

After applying the proposed fix locally, the compilation succeeded.


This is an automatic backport of pull request #117 done by [Mergify](https://mergify.com).

@christophebedard
Copy link
Member

christophebedard commented Jun 10, 2024

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@christophebedard christophebedard self-assigned this Jun 10, 2024
@christophebedard christophebedard merged commit 8ca3025 into jazzy Jun 10, 2024
8 of 9 checks passed
@christophebedard christophebedard deleted the mergify/bp/jazzy/pr-117 branch June 10, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants