Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tp_call.h to fix simple type without cast error #120

Closed
wants to merge 1 commit into from

Conversation

DragonflyRobotics
Copy link

While building ROS2 Iron on Arch with an updated PKGBUILD, there seems to be a type mismatch without cast from uin64_t to const uint64_t *, so I just changed it. Perhaps this could be something on my end but I would like to propose the change regardless. Please let me know if you want more details. I am building using colcon with the following PKGBUILD: https://github.com/DragonflyRobotics/ros2-iron-fork.

Disclaimer: I am not at all familiar with this codebase, but I am familiar with C++. This resolves the compile error but may break functionality, which I cannot anticipate, so any input is appreciated.

While building ROS2 Iron on Arch with an updated PKGBUILD, there seems to be a type mismatch without cast from uin64_t to const uint64_t *, so I just changed it. Perhaps this could be something on my end but I would like to propose the change regardless. 

Signed-off-by: Krishna Shah <[email protected]>
@christophebedard
Copy link
Member

This was fixed in rolling in #117 and then backported to jazzy in #119, but not backported to iron. I just opened a direct backport here: #121. I'll use that one and close this. Thank you for letting us know that it fails on Iron too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants