[CPyCppyy] Remove implicit conversion of any ctypes ptr type to void*
#16816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 18 files 18 suites 3d 18h 17m 11s ⏱️ For more details on these failures, see this check. Results for commit 5beb41b. ♻️ This comment has been updated with latest results. |
vepadulano
approved these changes
Nov 5, 2024
guitargeek
force-pushed
the
cppyy_ctypes_patch
branch
from
1ec1d64
to
e18b7a2
Compare
The `IsCTypesArrayOrPointer` gives false positives in Python 3.13, resulting the void pointer converter to take the wrong code path and crash. See: wlav/cppyy#272 This code path is used for implicit conversion from other `ctypes` pointer types to `void*`, which is not strictly required. One can always do an explicit cast: `ctypes.cast(my_ptr, ctypes.c_void_p )`. Given that this a niche feature that broke Python 3.13 support for functions taking `void*`, which is quite common, it can be argued that it's better to remove this implicit conversion. This commit fixes the following tests under Python 3.13: ``` roottest-python-basic-datatype roottest-python-cpp-cpp ``` This reverts the following commit from upstream: wlav/CPyCppyy@80a0205
guitargeek
force-pushed
the
cppyy_ctypes_patch
branch
from
e18b7a2
to
5beb41b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
IsCTypesArrayOrPointergives false positives in Python 3.13, resulting the void pointer converter to take the wrong code path and crash. See:wlav/cppyy#272
This code path is used for implicit conversion from other
ctypespointer types tovoid*, which is not strictly required. One can always do an explicit cast:ctypes.cast(my_ptr, ctypes.c_void_p ).Given that this a niche feature that broke Python 3.13 support for functions taking
void*, which is quite common, it can be argued that it's better to remove this implicit conversion.This commit fixes the following tests under Python 3.13:
This reverts the following commit from upstream:
wlav/CPyCppyy@80a0205
See also the Fedora 41 CI PR:
#16748