Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CPyCppyy] Fix regression in passing buffers through void * #16861

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

guitargeek
Copy link
Contributor

Credit goes to Wim Lavrijsen (@wlav).

See also: wlav/cppyy#272.

Following up on #16816, hopefully fixing the problem without sacrificing any features.

Copy link

github-actions bot commented Nov 7, 2024

Test Results

    18 files      18 suites   3d 19h 12m 18s ⏱️
 2 664 tests  2 664 ✅ 0 💤 0 ❌
46 152 runs  46 152 ✅ 0 💤 0 ❌

Results for commit 8687a02.

Copy link
Member

@vepadulano vepadulano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor curiosity, rest looks good thanks!

Comment on lines +16 to +17
def stringpager(text, title='', cls=cls):
cls.helpout.append(text)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just curious to understand why the extra title kwarg, which looks like it's unused in the function

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's more of a question to @wlav who wrote this. But for ROOT it makes no difference at this point.

But let's try to run all these tests also in our CI in the future!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The interface of the pydoc pager changed in 3.13 with the addition of that title argument, but I'd rather have the test capture the same information only, i.e. the help-text body, than introduce differences in test behavior between versions. (If anything needs changing, this test needs a teardown to restore the old pager.)

@guitargeek guitargeek merged commit dca2707 into root-project:master Nov 8, 2024
20 of 22 checks passed
@guitargeek guitargeek deleted the py313_followup branch November 8, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants