-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update iDynTree to 12.3.3 and actually test FT sensor frame consistency #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
traversaro
changed the title
Update iDynTree to 12.3.3
Update iDynTree to 12.3.3 and actually test FT sensor frame consistency
Jul 8, 2024
Great, apparently we were not even running test in CI, now I enabled them. |
Great, the tests are now failing:
|
Specific error:
|
…URDF frames for a single simmechanics frame See robotology/simmechanics-to-urdf#62 Fix #275 .
By updating to the version of simmechanics-to-urdf with the fix in robotology/simmechanics-to-urdf#62, the test pass fine. These introduces back the frames
|
Unfortunately, after this fix the test pass again, so we do not have useful tests to debug #271 . |
martinaxgloria
approved these changes
Jul 9, 2024
Nicogene
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iDynTree 12.3.3 fixed a bug that prevented to properly test if the FT sensors were properly exported (robotology/idyntree#1191), updating the iDynTree version should ensure that we catch #275 and ideally #271 .