Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build js error & Update Editable(Mesh/Image) inheritance #1321

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+3 −3
Open

Fix build js error & Update Editable(Mesh/Image) inheritance #1321

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72cd24c
Update customDefinitions.d.ts
SnorlaxAssist Oct 28, 2024
3b0868d
Update Editable* to extend off Object
SnorlaxAssist Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions include/customDefinitions.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,11 +341,11 @@ interface Dragger extends Instance {
MouseDown(this: Dragger, mousePart: BasePart, pointOnMousePart: Vector3, parts: Array<BasePart>): void;
}

interface EditableImage extends Instance {
interface EditableImage extends Object {
ReadPixels(this: EditableImage, position: Vector2, size: Vector2): Array<number>;
}

interface EditableMesh extends DataModelMesh {
interface EditableMesh extends Object {
FindClosestPointOnSurface(this: EditableMesh, point: Vector3): LuaTuple<[number, Vector3, Vector3]>;
FindVerticesWithinSphere(this: EditableMesh, center: Vector3, radius: number): Array<number>;
GetAdjacentTriangles(this: EditableMesh, triangleId: number): Array<number>;
Expand Down Expand Up @@ -540,7 +540,7 @@ interface InsertService extends Instance {
GetUserSets(this: InsertService, userId: number): Array<SetInfo>;
}

interface Instance {
interface Instance extends Object {
/**
* **Clone** creates a copy of an object and all of its descendants, ignoring all objects that are not [Archivable](https://developer.roblox.com/en-us/api-reference/property/Instance/Archivable). The copy of the root object is returned by this function and its [Parent](https://developer.roblox.com/en-us/api-reference/property/Instance/Parent) is set to nil.
*
Expand Down
Loading