New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build js error & Update Editable(Mesh/Image) inheritance #1321

Open

SnorlaxAssist wants to merge 2 commits into roblox-ts:master from SnorlaxAssist:build-fix

Contributor

SnorlaxAssist commented Oct 28, 2024 •

edited

Loading

Fixes #1320

Updates EditableImage and EditableMesh inheritance to Object. (Based on this)

This might not be the ideal solution, ever since Roblox added Object class, which overlaps with roblox-ts/compiler-types version of Object

SnorlaxAssist added 2 commits

October 28, 2024 02:19


          Update customDefinitions.d.ts

72cd24c

Instance extends object


          Update Editable* to extend off Object

3b0868d

"EditableImage and EditableMesh now inherit from Object instead of Instance."

SnorlaxAssist changed the title ~~Fix build error when generating types~~ Fix build js error & Update Editable(Mesh/Image) inheritance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet