Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update encoding.h to get rid of erroneous define #1834

Merged
merged 1 commit into from
Oct 14, 2024
Merged

update encoding.h to get rid of erroneous define #1834

merged 1 commit into from
Oct 14, 2024

Conversation

aap-sc
Copy link
Contributor

@aap-sc aap-sc commented Oct 14, 2024

No description provided.

@aap-sc
Copy link
Contributor Author

aap-sc commented Oct 14, 2024

@aswaterman I've encountered a minor warning during the build. Looks like you've already fixed this in riscv/riscv-opcodes#288 , so this is just a minor update

aswaterman
aswaterman approved these changes Oct 14, 2024
View reviewed changes
Copy link
Collaborator

@aswaterman aswaterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, thanks for making the corresponding Spike update.

@aswaterman aswaterman merged commit aacfc53 into riscv-software-src:master Oct 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aswaterman aswaterman aswaterman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aap-sc @aswaterman